Skip to content

Commit 5f834ed

Browse files
paulirishWilcoFiers
authored andcommitted
perf: Speed up getNodeFromTree (#1302)
* fix: speed up getNodeFromTree * remove return value for clear semantics * fix early return nit
1 parent b9d1b57 commit 5f834ed

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

lib/core/utils/flattened-tree.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,13 @@ axe.utils.getNodeFromTree = function(vNode, node) {
142142
return vNode;
143143
}
144144
vNode.children.forEach(candidate => {
145-
var retVal;
146-
145+
if (found) {
146+
return;
147+
}
147148
if (candidate.actualNode === node) {
148149
found = candidate;
149150
} else {
150-
retVal = axe.utils.getNodeFromTree(candidate, node);
151-
if (retVal) {
152-
found = retVal;
153-
}
151+
found = axe.utils.getNodeFromTree(candidate, node);
154152
}
155153
});
156154
return found;

0 commit comments

Comments
 (0)