Skip to content

Commit 737c81c

Browse files
committed
fix(perf): Improve getSelector performance
1 parent 9c7b9f1 commit 737c81c

File tree

11 files changed

+777
-371
lines changed

11 files changed

+777
-371
lines changed

lib/core/base/audit.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ Audit.prototype.run = function (context, options, resolve, reject) {
180180
}
181181
});
182182
q.then(function (results) {
183-
axe._tree = undefined; // empty the tree
184183
axe._selectCache = undefined; // remove the cache
185184
resolve(results.filter(function (result) { return !!result; }));
186185
}).catch(reject);

lib/core/public/run.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ axe.run = function (context, options, callback) {
127127
try {
128128
let reporter = axe.getReporter(options.reporter);
129129
let results = reporter(rawResults, options, respond);
130+
axe._selectorData = undefined;
131+
axe._tree = undefined;
130132
if (results !== undefined) {
131133
respond(results);
132134
}

lib/core/utils/collect-results-from-frames.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11

22
function err(message, node) {
33
'use strict';
4-
return new Error(message + ': ' + axe.utils.getSelector(node));
4+
var selector;
5+
if (axe._tree) {
6+
selector = axe.utils.getSelector(node);
7+
}
8+
return new Error(message + ': ' + (selector || node));
59
}
610

711
/**

0 commit comments

Comments
 (0)