fix: make getSelector work with URIs that cannot be shortened

dequelabs · Mar 8, 2018 · a113555 · a113555
1 parent a5ea385
commit a113555
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/lib/core/utils/get-selector.js b/lib/core/utils/get-selector.js
@@ -22,12 +22,17 @@ function getAttributeNameValue(node, at) {
 	let atnv;
 
 	if (name.indexOf('href') !== -1 || name.indexOf('src') !== -1) {
-		let value = encodeURI(axe.utils.getFriendlyUriEnd(node.getAttribute(name)));
-		if (value) {
-			atnv = escapeSelector(at.name) + '$="' + value + '"';
-		} else {
-			return;
-		}
+			let friendly = axe.utils.getFriendlyUriEnd(node.getAttribute(name));
+			if (friendly) {
+				let value = encodeURI(friendly);
+				if (value) {
+					atnv = escapeSelector(at.name) + '$="' + value + '"';
+				} else {
+					return;
+				}
+			} else {
+				atnv = escapeSelector(at.name) + '="' + node.getAttribute(name) + '"';
+			}
 	} else {
 		atnv = escapeSelector(name) + '="' + escapeSelector(at.value) + '"';
 	}

diff --git a/package.json b/package.json
@@ -91,4 +91,4 @@
     "standard-version": "^4.2.0"
   },
   "dependencies": {}
-}
+}
diff --git a/test/core/utils/get-selector.js b/test/core/utils/get-selector.js
@@ -551,6 +551,16 @@ describe('axe.utils.getSelector', function () {
 		);
 	});
 
+	it('should work correctly when a URL attribute cannot be shortened', function () {
+		var href = 'mars2.html?a=be_bold';
+		var node = document.createElement('a');
+		node.setAttribute('href', href);
+		fixture.appendChild(node);
+		axe._tree = axe.utils.getFlattenedTree(document.documentElement);
+
+		assert.include(axe.utils.getSelector(node), href);
+	});
+
 	it('no options: should work with shadow DOM', function () {
 		var shadEl;