Release v3.2.0 #1401
Merged
Release v3.2.0 #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a new task which ensures, existence of a given set of files. In this case it checks, for `axe.***.js` files for all langs specified. If the build generated files do not exist, a fatal error is thrown. Also, the same files are checked for existence as a part of `prepublishOnly` step. <img width="504" alt="screen shot 2018-09-12 at 08 54 26" src="https://user-images.githubusercontent.com/20978252/45410410-85f44680-b669-11e8-9649-8d02dc4bb3df.png"> Closes issue: - #1117 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
## Summary Add Terra to Project List Closes issue: N/A ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
## The devDependency [husky](https://github.com/typicode/husky) was updated from `0.14.3` to `1.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- [Find out more about this release](https://github.com/typicode/husky). <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 ---- **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: Jey
This PR enhances `html-lang-valid` rule to allow `xml:lang` attribute. Closes issue: - #1140 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
…riate (#1156) A minor fix that was missed in #983 Closes issue: #983 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
This patch removes our unused `postinstall` script. It looks like we were previously installing a commit message validation hook (`angular-precommit`), but this no longer works. If we want to validate commit messages moving forward, I suggest using Husky for this sort of thing. Closes #1169. ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
* fix: consider element's accessible names when labels are hidden Closes #1176 * chore: revert condition for pr review * chore: update to use `isVisble` sr mode
chore(package): update husky to version 1.1.1
chore: Update lint-staged to the latest version 🚀
This PR, allows role `presentation`/ `none` on `object`. Closes issue: - #1221 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
This is a maintenance PR, to update `node.tagName` usages to `node.nodeName`. Did not update the usages in: - `lib/core/utils/css-parser.js` - as this is a copy/pasted (imported) module. - `lib/core/utils/qsa.js` - as this seems to break a lot of tests. Closes issue: - #942 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: << Marcy Sutton >>
fix(aria-allowed-role): Allow iframe role=none [#1360]
chore: Resolve a few a11y-name comments
chore: Rename multiple-label files
Revert "fix(rule): frame-title applies to wcag242"
…#1335) * chore(WIP): rewrite accessibleText * chore: More refactoring for accname * chore(WIP): More improvements to accessibleName * feat: Reimplement accessible name computation * chore: All accessible name tests passing * chore(accName): All tests passing * chore: Add tests * chore: Test form-control-value * chore: Refactor and add docs to accessible-text * chore: Add tests for namedFromContents * chore: Refactor subtreeText method * chore: Refactor native accessible text methods * chore: Coverage for text.labelText * fix: update to axe.commons.matches usage * test: fix nativeTextboxValue tests * test: fix failing tests * fix: compute includeHidden as a part of accessibleName fn * fix: do not mutate context in accessibleText * feat: rule for label and name from content mismatch * fix: refactor based on review and add unicode computation * refactor: update based on code review * test: update test * chore: fix linting errors * refactor: updates based on code review * refactor: unicode and punctuation methods * test: update tests
fix: update success criteria for rule css orientation lock
Invoking `npm scripts` using `grunt-run` resulted in a child process spawn error in windows, as `grunt-run` perhaps could not resolve between `command prompt` vs `shell` internally. In our case, we are executing a `node` script via `npm script`, so it makes sense to run the `node` script directly using `grunt-run`, thus bypassing the above issue. The main change is here - https://github.com/dequelabs/axe-core/pull/1388/files#diff-35b4a816e0441e6a375cd925af50752cR334, rest are comments update and prettier going to town. Checked with Wahaj @waabid, who confirmed that this worked in his machine, also tested locally on windows via bootcamp. Closes issue: NA ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
…1382) Expand the `unsupported` property of an attribute by allowing certain elements to use the attribute. Closes: #1216 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
Translated new messages for "label-content-name-mismatch" Closes issue: N/A ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
WilcoFiers
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Audited the security reviews:
- Update babelify to the latest version 🚀 #1122
- fix: html-lang-valid should consider xml:lang #1152
- fix: CSSOM generation for shadowRoot in Safari #1113
- fix: consider element's accessible names when labels are hidden #1187
- fix: autocomplete street address #1217
- feat: separate form-field-multiple-label from label rule #1226
- fix(commons): Allow any node in aria.getRole #1258
- chore: import css-selector-parser via axe.imports #1280
- fix(rule): frame-title applies to wcag242 #1312
- fix(rule): frame-title applies to wcag242 #1312
- fix(i18n): Add Japanese translation #1395
Incident: PR #1122 was did not have a security review. That one was a greenkeeper PR, which I approved without leaving a comment about security reviews. I don't think this is a concern. Updating dependencies does not introduce security vulnerabilities that a security review would catch. While I do tend to leave a comment about the review, it seems I forgot this time around.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review 10% (50 max) of the following (Product manager only):
Note: This release was manually generated.
Steps followed:
release-320fromdevelop.npm run release, which bumped versions and created CHANGELOG.