Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/element-matches.js): Use node.matches* in place of prototype.matches* #956

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

zkf
Copy link
Contributor

@zkf zkf commented Jun 18, 2018

Closes #953

PR Checklist

Please check if your PR fulfills the following requirements:

Description of the changes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I ran grunt test under Linux which fired up two instances of Chromium and one of Firefox. I’m guessing it also used PhantomJS. There was one failure reported, but it was present before these changes were applied:

>> URL: http://localhost:9876/test/commons/
>> Describe: color.getBackgroundColor
>> it should ignore inline ancestors of non-overlapping elements
>> AssertionError@http://localhost:9876/node_modules/chai/chai.js:9320:13                                                             
>> [3]</module.exports/Assertion.prototype.assert@http://localhost:9876/node_modules/chai/chai.js:239:13                              
>> [6]</module.exports/assert.equal@http://localhost:9876/node_modules/chai/chai.js:4218:5                                            
>> @http://localhost:9876/test/commons/color/get-background-color.js:365:3  

I was unable to find information on how to run the automated test suite on IE, Safari and Chrome for Android.

@WilcoFiers WilcoFiers merged commit ebdb590 into dequelabs:develop Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utils.matchesSelector() failing on page where the Element prototype has been modified
2 participants