feat: add watcher fixtures #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2023
michael-siek
approved these changes
Sep 2, 2023
Zidious
commented
Sep 2, 2023
Comment on lines
+10
to
+36
| <div style="margin-bottom: 5em"> | ||
| <h2>Test Case 1 - Button Click</h2> | ||
|
|
||
| <div id="color-block">This isn't readable is it...</div> | ||
| <button onclick="updateColour()">Click me</button> | ||
|
|
||
| <style> | ||
| #color-block { | ||
| background-color: white; | ||
| color: white; | ||
| width: 100px; | ||
| height: 100px; | ||
| margin-bottom: 1em; | ||
| display: none; | ||
| } | ||
| </style> | ||
|
|
||
| <script> | ||
| function updateColour() { | ||
| const colorBlock = document.getElementById("color-block"); | ||
| colorBlock.style.backgroundColor = "gray"; | ||
| colorBlock.style.display = "block"; | ||
|
|
||
| document.title = "Watcher - Test Case 1 - Button Click"; | ||
| } | ||
| </script> | ||
| </div> |
There was a problem hiding this comment.
Decided to put script and style tags within each div "test block". Can merge them all necessary, this reads easier but no strong opinion here.
|
Is this the right place for this test fixture? We've been using this strictly for all the apis to have tests, watcher is outside that scope. Is there a reason this doesn't belong in the watcher repo? |
straker
previously requested changes
Sep 5, 2023
Clarification for readers: discussed during standup - watcher related fixtures will have a home here under |
michael-siek
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see referenced ticket