fix(style): synced text field styles with pattern library #1206
Conversation
|
Preview branch generated at https://fix-sync-text-field-with-uxpin.d1gko6en628vir.amplifyapp.com |
There was a problem hiding this comment.
A couple of things here:
The error field focus ring shifts content during focus (see below video), the footprint of the element should not be shifting content on the page:
cauldron-error-textfield-focus.mov
The default focus ring still appears to be too large, according to our pattern library it needs to be 1px smaller.
Minor nit: the commit message / pr title should be more descriptive in describing what changed. Something like "synced text field styles with pattern library". Otherwise, it will be difficult to know what actually changed when it gets placed in the changelog.
We need to also ensure that any style changes are reflected on Combobox as well. Combobox isn't a 1:1 of textfield and has to duplicate a few styles over as it cannot use the textfield styles directly.
orest-s
changed the title
There was a problem hiding this comment.
Changes here look good for the textfield/combobox error focus ring changes.
It does look like we're still missing the following from the issue:
- Focus ring should be 1px smaller (currently appears to be 3px)
The above applies to the default "blue" focus ring that gets applied, so we just need to shrink both TextField and Combobox by 1px.
This is also an existing issue, but I noticed that hover state of the combobox error is currently using the wrong focus color that would be nice to sync up here as well:
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Closes: #1070