Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): Synced styles and added large variant of IconButton #1304

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

orest-s
Copy link
Contributor

@orest-s orest-s commented Dec 27, 2023

Closes: #1175 and #969.
Also PR closes partly (only for icon-button): #938

@orest-s orest-s requested review from a team as code owners December 27, 2023 12:52
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1304.d15792l1n26ww3.amplifyapp.com

Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also appears that the disabled active state has a background color (see #938) which we likely want to fix here. We can leave #938 open to address the standard buttons at a later time.

docs/pages/components/IconButton.mdx Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Show resolved Hide resolved
packages/styles/icon-button.css Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
packages/styles/icon-button.css Outdated Show resolved Hide resolved
@orest-s orest-s requested a review from scurker January 4, 2024 13:30
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Just want to get a 👍 from @dequelabs/cauldron-design

Copy link

@shawnsharpDQ shawnsharpDQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design gives 2 👍 up!

@scurker scurker merged commit e5868a1 into develop Jan 23, 2024
7 checks passed
@scurker scurker deleted the feat/sync-icon-buttons branch January 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync IconButton with UXPin
3 participants