Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): fix incorrect icon size with Dialog close buttons #1327

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(styles): fix incorrect icon size with Dialog close buttons #1327

merged 1 commit into from
Jan 31, 2024

Conversation

scurker
Copy link
Member

@scurker scurker commented Jan 30, 2024

Noticed there was a visual regression with the close button:

cauldron modal with x misaligned in close button

@scurker scurker requested a review from a team as a code owner January 30, 2024 20:02
@scurker scurker requested a review from a team January 30, 2024 20:02
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1327.d15792l1n26ww3.amplifyapp.com

@scurker scurker merged commit f877edf into develop Jan 31, 2024
6 checks passed
@scurker scurker deleted the fix-icon-size-dialog branch January 31, 2024 16:33
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thuey thuey thuey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scurker @thuey