Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: upgrade jest dependencies to 29.x #1331

Merged
merged 3 commits into from
Feb 1, 2024
Merged

test: upgrade jest dependencies to 29.x #1331

merged 3 commits into from
Feb 1, 2024

Conversation

scurker
Copy link
Member

@scurker scurker commented Jan 31, 2024

Slight test refactor to get jest upgraded including:

  • updating jest and @type/jest to 29.x
  • setting testEnvironment to jsdom
  • move jest configuration out of package.json and into separate config file

There were a number of tests failing likely do to the jsdom environment change, related to document.activeElement. I realize the changes in the test may not be the ideal way to test for these changes, but I did not want to spend a lot of time as we will be addressing testing once we update tests to use react-testing-library.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1331.d15792l1n26ww3.amplifyapp.com

@scurker scurker requested a review from a team January 31, 2024 21:21
@scurker scurker marked this pull request as ready for review January 31, 2024 21:21
@scurker scurker requested a review from a team as a code owner January 31, 2024 21:21
@scurker scurker merged commit 50ad8e3 into develop Feb 1, 2024
7 checks passed
@scurker scurker deleted the jest-upgrade branch February 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants