Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): fix incorrect aria when Combobox has no results #1332

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix(react): fix incorrect aria when Combobox has no results #1332

merged 1 commit into from
Feb 1, 2024

Conversation

scurker
Copy link
Member

@scurker scurker commented Jan 31, 2024

closes #1330

@scurker scurker requested a review from a team January 31, 2024 22:37
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1332.d15792l1n26ww3.amplifyapp.com

@scurker scurker marked this pull request as ready for review January 31, 2024 22:47
@scurker scurker requested a review from a team as a code owner January 31, 2024 22:47
@scurker scurker merged commit 023ddac into develop Feb 1, 2024
6 checks passed
@scurker scurker deleted the fix-combobox-no-results branch February 1, 2024 18:01
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thuey thuey thuey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox no results found raises axe-core issue
2 participants
@scurker @thuey