Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): use default hover cursor when checkboxes are disabled #1340

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

JoshMK
Copy link
Contributor

@JoshMK JoshMK commented Feb 7, 2024

  • CSS adjustment to use the default hover cursor on non-intractable disabled checkboxes

Closes issue: #1339

@JoshMK JoshMK requested a review from a team as a code owner February 7, 2024 20:17
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1340.d15792l1n26ww3.amplifyapp.com

packages/styles/forms.css Outdated Show resolved Hide resolved
scurker
scurker previously approved these changes Feb 7, 2024
packages/styles/forms.css Outdated Show resolved Hide resolved
packages/styles/forms.css Outdated Show resolved Hide resolved
@JoshMK JoshMK force-pushed the fix-1339-disabled-checkbox-cursor branch 2 times, most recently from a6871a0 to e98d332 Compare February 8, 2024 16:08
@JoshMK JoshMK requested a review from scurker February 8, 2024 16:09
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules are duplicative of the lines below so you only need to include cursor: default once for both the unchecked and checked styles. There should only be a single set of rules for .Checkbox__overlay--disabled.Icon--checkbox-unchecked, .Radio__overlay--disabled.Icon--radio-unchecked

.Checkbox__overlay--disabled.Icon--checkbox-unchecked,
.Radio__overlay--disabled.Icon--radio-unchecked {
color: var(--field-icon-unchecked-disabled-color);
cursor: default;
}
.Checkbox__overlay--disabled.Icon--checkbox-unchecked,
.Radio__overlay--disabled.Icon--radio-unchecked {
color: var(--field-icon-unchecked-disabled-color);
}

@JoshMK JoshMK force-pushed the fix-1339-disabled-checkbox-cursor branch from e98d332 to 2f9eee4 Compare February 8, 2024 20:31
@JoshMK JoshMK requested a review from scurker February 8, 2024 20:32
@scurker scurker changed the title fix: use default hover cursor when checkboxes are disabled fix(react): use default hover cursor when checkboxes are disabled Feb 8, 2024
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JoshMK JoshMK merged commit 3818823 into develop Feb 9, 2024
7 checks passed
@JoshMK JoshMK deleted the fix-1339-disabled-checkbox-cursor branch February 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants