-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): use default hover cursor when checkboxes are disabled #1340
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
96f8957
to
460d059
Compare
a6871a0
to
e98d332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rules are duplicative of the lines below so you only need to include cursor: default
once for both the unchecked and checked styles. There should only be a single set of rules for .Checkbox__overlay--disabled.Icon--checkbox-unchecked, .Radio__overlay--disabled.Icon--radio-unchecked
cauldron/packages/styles/forms.css
Lines 445 to 454 in e98d332
.Checkbox__overlay--disabled.Icon--checkbox-unchecked, | |
.Radio__overlay--disabled.Icon--radio-unchecked { | |
color: var(--field-icon-unchecked-disabled-color); | |
cursor: default; | |
} | |
.Checkbox__overlay--disabled.Icon--checkbox-unchecked, | |
.Radio__overlay--disabled.Icon--radio-unchecked { | |
color: var(--field-icon-unchecked-disabled-color); | |
} |
e98d332
to
2f9eee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes issue: #1339