Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse mode red bars proportioned wrong in some cases #592

Closed
eldada opened this issue Mar 1, 2020 · 4 comments
Closed

Pulse mode red bars proportioned wrong in some cases #592

eldada opened this issue Mar 1, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@eldada
Copy link
Contributor

eldada commented Mar 1, 2020



Describe the bug
In the (AWESOME) pulse mode - command pu, there are cases where the bars of the red errors are badly displayed over other areas. This happens to me only when terminal is maximised.
Also green is not shown at that part.

To Reproduce
Steps to reproduce the behavior:

  1. Have a cluster with many errors
  2. Go to pulse mode (command 'pu')
  3. See red bars expand beyond the are they should be. See attached image

Expected behavior
Red bars in their provided area

Screenshots
Screen Shot 2020-03-01 at 16 19 47

Versions (please complete the following information):

  • OS: OSX
  • K9s: 0.17.1
  • K8s: EKS 1.14.9

Additional context
Once I change the size of the terminal in my screen, the issue seem to go away...

@derailed derailed added the bug Something isn't working label Mar 1, 2020
@derailed
Copy link
Owner

derailed commented Mar 2, 2020

@eldada Thank you for this report and kind words! Haven't really heard any feedback on the pulses view so I thought this feature was a dud ;( So happy to hear this! I think I've found the issue. Will drop a fix next. Thank you Eldad!!

@eldada
Copy link
Contributor Author

eldada commented Mar 2, 2020

This feature has great potential. We manage many clusters, and this helps me get a quick health status of my cluster and easy drill down. 😊

derailed added a commit that referenced this issue Mar 2, 2020
@derailed
Copy link
Owner

derailed commented Mar 2, 2020

Wonderful! Thank you for the feedback as always!!

@eldada
Copy link
Contributor Author

eldada commented Mar 3, 2020

Fix confirmed! Thx guys for the prompt response 😁 👍

@eldada eldada closed this as completed Mar 3, 2020
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants