Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus colors on scale dialog buttons #1277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidalger
Copy link
Contributor

Before this change the scale dialog looks like this when a button is selected:

image

After this change, the buttons are correctly styled using the focus colors set in my skin file:

image

@derailed derailed added the question Further information is requested label Oct 21, 2021
@davidalger
Copy link
Contributor Author

@derailed Is there anything I could do to help move this forward? Any chance you could merge it please?

@ScubaDrew
Copy link

@derailed Hi, I am a sponsor, asking kindly if you can review this MR. Thank you, sir!

@placintaalexandru
Copy link
Contributor

placintaalexandru commented Aug 21, 2023

hello @ScubaDrew . I fixed this in this #2150 in all possible places that I could discover so that dialog boxes use the styles specified in skin.yaml file.

Please find the bug ticket (#2149) and update it if you find other places that need to be fixed.

I propose to close this one and keep the bug ticket as source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants