Added defaultsToFullScreen flag for Live/Details view,logs #2516
Conversation
README.md
Outdated
| # By default all contexts wil use the dracula skin unless explicitly overridden in the context config file. | ||
| skin: dracula # => assumes the file skins/dracula.yaml is present in the $XDG_DATA_HOME/k9s/skins directory | ||
| # By default start all Live_View in full screen mode. (yaml, helm history, describe, value_extender) Default false | ||
| fullScreenLView: false |
There was a problem hiding this comment.
Wondering if we could use a a better name for this??
Perhaps fullScreen or defaultsToFullScreen or activateFullScreen might be better choices??
Likely if users opt to default to FS likely the logs should operate as such. So I am thinking we should axe the log fullScreen and go with a single option to configure this ui bit in just one place??
What do you think?
There was a problem hiding this comment.
I think having a defaultsToFullScreen option under Ui which sets all live/details view and logs is a better option.
For the naming I don't like fullScreenLView but fullScreen or defaultsToFullScreen in UI sounds like it is about the whole K9S not just the "popup" views. Since I could not come up with a better one I will just use defaultsToFullScreen.
There was a problem hiding this comment.
Thanks for the feedback Adam! Good point! I think that make sense.
Likely in the future we may end up breaking out sub-sections under UI for details view configs.
| return nil | ||
| } | ||
|
|
||
| func (v *LiveView) setFullScreen(isFullScreen bool) { |
There was a problem hiding this comment.
Likely we should refactor Live/Details view to offer this functionality.
There was a problem hiding this comment.
I added same functionality for Details view, if you could kindly check if thats what you meant by "refactor Live/Details view" that would be great.
There was a problem hiding this comment.
Right I was thinking combining the 2 to dry this up in a single place. This feels like a sep PR tho.
|
@derailed Thanks for this review as well, I believe I made the modifications. |
eiachh
changed the title
| return nil | ||
| } | ||
|
|
||
| func (v *LiveView) setFullScreen(isFullScreen bool) { |
There was a problem hiding this comment.
Right I was thinking combining the 2 to dry this up in a single place. This feels like a sep PR tho.
…2516) * Added fullScreen flag for LiveView, updated readme.md * Added fullScreenLView default value for tests * Extended DefaultsToFullScreen to include logView and DetailsView
Added fullScreenlView flag to config.yaml to allow setting default behaviour for LiveView which includes yaml, helm history, describe, value_extender. 2506
I am not quite sure if this flag is the best under UI.