Simplify Cruder Interface #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
changed the title
derailed
reviewed
Nov 8, 2019
|
@paivagustavo Awesome!! Totally makes sense and reduce the interface footprint. Great catch. Thank you!! Just a small pic (see comment). Great job!! |
|
@paivagustavo Thank you!! |
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Simplify Cruder Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the
CruderInterface. Moving the allocation of themetav1.ListOptionsto the calleer of theListmethod.Now the
liststruct is responsible to holding the label and filter selector.This is the start for us having a simpler way to configure our filter and tackle down the #336