Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popeye showing errors for Complete cronjobs #298

Closed
jim-barber-he opened this issue Mar 20, 2024 · 6 comments
Closed

Popeye showing errors for Complete cronjobs #298

jim-barber-he opened this issue Mar 20, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@jim-barber-he
Copy link




Describe the bug

For some reason when evaluating CRONJOBS, popeye shows errors for complete jobs.
A Pod produced from a Job that has been created by a CronJob that has finished with a status of Completed isn't a problem?

To Reproduce
Steps to reproduce the behavior:

Create a simple cronjob. Something like this should suffice:

apiVersion: batch/v1
kind: CronJob
metadata:
  name: test-cron
spec:
  concurrencyPolicy: Forbid
  failedJobsHistoryLimit: 1
  jobTemplate:
    spec:
      activeDeadlineSeconds: 60
      backoffLimit: 0
      template:
        spec:
          automountServiceAccountToken: false
          containers:
          - command:
            - /usr/bin/sleep
            - "10"
            image: debian:stable-slim
            imagePullPolicy: IfNotPresent
            name: cronjob
          restartPolicy: Never
  schedule: '* * * * *'
  successfulJobsHistoryLimit: 3

And apply it. E.g.: kubectl apply -f $CRONJOB_YAML

After the job has run a couple of times, run popeye -s cronjobs and you'll see the error.

Expected behavior

I don't think cronjobs having completed jobs is a problem?
If so, why?
And if they are, this error doesn't have a POP-???? code that can be used to filter it out.

Screenshots

From the example cronjob above:
image

Versions (please complete the following information):

  • OS: Debian 12
  • Popeye: 0.21.1
  • K8s: 1.28.8

Additional context

derailed added a commit that referenced this issue Mar 26, 2024
@derailed
Copy link
Owner

@jim-barber-he Thanks for the heads up! Fix v0.21.2

@derailed derailed added the bug Something isn't working label Mar 26, 2024
@jim-barber-he
Copy link
Author

Now with that test CronJob above I'm getting this error. What does it mean?
image

$ popeye version | grep Version
Version:   0.21.2

@jim-barber-he
Copy link
Author

Also in our prod cluster we see messages like:
image

@jim-barber-he
Copy link
Author

Oh I guess that's the same. I didn't notice the Delete was caught in the first screenshot as well.

derailed added a commit that referenced this issue Mar 27, 2024
@derailed
Copy link
Owner

@jim-barber-he My apologies. These mean I need m'o sleep ;(
Let see if we're happier on v0.21.3

@jim-barber-he
Copy link
Author

Thank you very much. I can confirm this is good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants