State history #385
Closed
State history #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonbloom
force-pushed
the
state-history
branch
from
201b884
to
11cf322
Compare
brandonbloom
force-pushed
the
main
branch
20 times, most recently
from
d4e2433
to
f757337
Compare
brandonbloom
force-pushed
the
state-history
branch
from
11cf322
to
54f15c5
Compare
|
Concepts need to evolve here. This component state store might actually be better as a resources store. The idea is that "component state" is roughly the most-recent/current "resource" assigned to the component. This is usually not an important distinction, but in the future, there may be two simultaneous resources for a component. For example, when deploying a new version to replace an old version with zero downtime. |
|
Closing this, as I'm basically going to rework all of the internals. May reuse a bunch of this code at some point, we'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much work-in-progress. Just sharing for awareness and potential feedback.
The new interface in this PR supports component state storage independent from specification. This simplifies/isolates the logic for state handling. The new interface supports historical states, which will be useful for debugging. Isolated state storage also means that we may be able to support remote state storage, which is important for stacks shared between multiple users in a deployment scenario.
The intention is that many controller actions should be able to operate entirely on state without component specifications. This means that existing controllers might have to change to copy some additional information into the state to make that possible. This will help with recovering from bad specs (#270).
This PR is safe to land, but isn't necessarily worth it to do so, since the new state storage interface isn't actually in use yet. To avoid complex multi-stage migrations, I'll probably storm forward with the new component storage step as well, before merging or after merging, but before switching over.
To be clear: This is step 1, extracted from a very large refactor.