Rework exo.hcl conversion for docker compose #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonbloom
force-pushed
the
simplify-compose-convert
branch
from
754a701
to
36840da
Compare
brandonbloom
force-pushed
the
simplify-compose-convert
branch
2 times, most recently
from
8dd4709
to
7eb95b8
Compare
|
This is almost ready. I've reimplemented all the logic except handling the "depends_on" that are implicit in the component spec as service "links" or explicit in "depends_on", but not part of the component-level non-spec stuff. |
brandonbloom
force-pushed
the
simplify-compose-convert
branch
from
7eb95b8
to
cc729ae
Compare
This logic will have to live somewhere else, but this wasn't the place for it. Converted HCL files should be as similar to the source compose files as possible.
brandonbloom
force-pushed
the
simplify-compose-convert
branch
from
cc729ae
to
89e0c65
Compare
This was referenced Oct 29, 2021
|
Closing in favor of ongoing work in #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the docker compose -> exo.hcl conversion to avoid doing any docker-compose magic at the manifest level. Instead, the logic is pushed down in to controllers, so folks who import compose files get nice clean exo.hcl files.