Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case when we have two same prefixes in the name #147

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

eliskovets
Copy link
Contributor

@eliskovets eliskovets commented Sep 14, 2023

Fix case when we have two same prefixes in the name

Previous behaviour:

>>> from nameparser import HumanName
>>> HumanName("van ma van").as_dict()
{'title': '', 'first': ' ', 'middle': 'van ma', 'last': 'van', 'suffix': '', 'nickname': ''}

Fixed behaviour:

>>> from nameparser import HumanName
>>> HumanName("van ma van").as_dict()
{'title': '', 'first': 'van ma', 'middle': '', 'last': 'van', 'suffix': '', 'nickname': ''}

@eliskovets
Copy link
Contributor Author

Hello @derek73,
Thank you for the lib, very useful.
Could you please take another looks at this PR? I've pulled changes from the main branch to fix CI.

Thank you!

@derek73 derek73 merged commit ff64838 into derek73:master Sep 20, 2023
5 checks passed
@eliskovets eliskovets deleted the bug/two-equal-prefixes branch September 21, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants