Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify development via docker compose #87

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nachtjasmin
Copy link

YAML anchors are nice, but also a bit hard to read. Instead of that,
we're using a dedicated .env file with several values. Also, we provide
a simple no-op configuration that's used as the base.

That sample configuration reads the necessary configuration from the
passed environment variables and therefore makes it easy to adapt for
other container-based deployments, while offering an entry point for
contributions.

YAML anchors are nice, but also a bit hard to read. Instead of that,
we're using a dedicated .env file with several values. Also, we provide
a simple no-op configuration that's used as the base.

That sample configuration reads the necessary configuration from the
passed environment variables and therefore makes it easy to adapt for
other container-based deployments, while offering an entry point for
contributions.
Copy link
Owner

@derf derf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks \o/

This is neat, though I think we should iron out some kinks before merging it:

  • docker-compose.yml sets the "CRON" variable for the worker, but AFAIK there's nothing checking that variable and the worker actually tries to start a second frontend thread instead. One solution would be to check [ -n "$CRON" ] in docker-run.sh
  • When starting starting the containers for the first time, postgresql needs some time for initialization, but travelynx and cron try to use it right away and fail. I think docker-compose has some sort of ping / heartbeat / 'is the service really up' that the scripts can use to avoid this situation?

@nachtjasmin
Copy link
Author

Ah yes, good catch. Gonna work on those issues as soon as I find my spoons again :3

@nachtjasmin nachtjasmin marked this pull request as draft August 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants