Detect games specifying "the EA app" for their ThirdPartyManagedApp as Origin games #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, working. |
…s Origin games Note that the actual title has different case for different games (e.g. it's "the EA app" for one game, but "The EA App" for another)
CommandMC
force-pushed
the
fix/ea-app-meta
branch
from
5260bfb
to
baab9c8
Compare
2 tasks
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in this discussion on Discord, newer EA titles seem to specify "the EA app" as their ThirdPartyManagedApp, not "Origin" like before. Additionally, the name is not the same case for every game, so checking for it becomes ever so slightly more complicated.
I figured adding a new property
is_origin_gameto theGamedataclass would be the cleanest way to resolve this