Fixes #66 #67
Closed
Fixes #66 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 27, 2017 12:10
…ody (as seen in RT4.4.1)
|
I'll review it this weekend. @ParisLiakos if you have a chance, can you test this pull request against your attachment handling codebase? It would be good to test against another real-world case. |
|
Any news? Let me know if you run into any difficulties, I'll be happy to help. |
|
Sorry for the delay - I should be able to get to it this week. |
|
Sorry, i dont have the bandwidth to check.. Currently moving appartments, then I will be off for a week, so i wont have time to test this in the two coming weeks |
|
Merged in #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #66 for details