Some small Python ipmrovements #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed and memory optisimasttion according to: PEP 289 -- Generator Expressions https://www.python.org/dev/peps/pep-0289/
This reverts commit 75f5bbb.
Speed and memory optisimasttion according to: PEP 289 -- Generator Expressions https://www.python.org/dev/peps/pep-0289/
Should always be done using "is" or "is not"
Performance optimisation
|
Thanks for the changes! I've been busy lately, so there's merge conflicts :( Please fix them, but if you are unable to, I can merge your changes in manually. Just let me know. |
This may be more secure solution in case of all intermediate-level directories needed to contain the leaf directory: https://docs.python.org/2/library/os.html#os.makedirs
|
You are welcome. Could You please merge changes manually into "crack.py" & "scanner.py" ? It is just removing the "[]" around "max()" and "sum()". The rest of pull request should be up 2 date. |
|
I applied the changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.