Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: offset position on resize with percentPosition #698

Closed
desandro opened this issue May 8, 2015 · 12 comments
Closed

Safari: offset position on resize with percentPosition #698

desandro opened this issue May 8, 2015 · 12 comments
Labels

Comments

@desandro
Copy link
Owner

desandro commented May 8, 2015

See http://codepen.io/desandro/pen/JFpeg. When resizing window, items shift outside container before being reset into proper position

@fishheadcode
Copy link

Will there be a fix, soon? :)
We´ve got big problems at the site from our customer. It´s not like "1 or 2 Pixel", it´s more like that the "items" have the same margin (to the right) like item-size before the resizing ends.

@manufaktor
Copy link

Seems like a timing issue in _transitionTo. I fixed it by doing this:

if ( this.layout.options.percentPosition || (didNotMove && !this.isTransitioning) ) { 

(it doesn't really fix the issue, it just works for the obvious case but has side effects)

@thegregthomp
Copy link

Any luck on this one? @desandro

@thegregthomp
Copy link

I noticed this issue using Isotope and I realized downgrading fixed my issue. I was on 2.2.0 and downgraded to 2.1.1 and it fixed my issue.

@mattstein
Copy link

@manufaktor, is the side effect you refer to just killing off animation? I'm trying to figure out how to best work around this right now.

@mattstein
Copy link

@manufaktor Nevermind—I went ahead and tried it and appreciate your note. Good patch for now!

desandro added a commit to metafizzy/outlayer that referenced this issue Jun 29, 2015
set transition position in percent values


Fix Safari percentPosition bug; Ref desandro/masonry#698
@desandro
Copy link
Owner Author

I've been able to identify and fix the bug in Outlayer. The fix will be in the next release of Masonry.

Bug was related to Safari returns percent values for left, top styles, but other browsers return pixels.

@mattstein
Copy link

Sweet, thanks @desandro!

@desandro
Copy link
Owner Author

desandro commented Jul 2, 2015

Merged in v3.3.1.

@JonathanSoper
Copy link

@desandro thank you for adding this fix for Masonry... is there a way to fix this in Isotope as well without having to downgrade to 2.1.1? I did the downgrade and it fixed my Safari layout issue, but I would rather stay with the latest version, or else apply a patch manually if that's possible...

Thanks so much for all your hard work. :)

@desandro
Copy link
Owner Author

desandro commented Aug 4, 2015

@BaseNineStudios This fix was merged into Isotope v2.2.1. Looks to be resolved, see demo http://codepen.io/desandro/pen/mIkhq

@JonathanSoper
Copy link

@desandro, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants