-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N(z) K-S test to identify bad fibers in jura #2283
Comments
If I run the same test on the ELGs without the OII quality cuts, the K-S test finds 129 fibers with p-value below the (more restrictive) threshold of 2e-6. This large number of "bad" fibers are perhaps expected since 20-30% of the ELG targets are low-S/N featureless spectra, and their redshifts can be sensitive to subtle CCD defects (which can otherwise be ignored for any spectrum with reasonable S/N). Still there might be useful information in their redshift vs date plots, and they can be found here: Alternatively we can simply look at ELG spectra that pass the OII cuts (here instead of zcatalog, I use Ashley's LSS catalog which includes the OII columns). This flags 10 fibers with p-value<1e-4: |
Julien and I have looked into some of the fibers. Here are the preliminary conclusions: 466: already flagged in Y1. Nothing obvious. ~20% low flat field. 3969: Also at the beginning of a CTE charge trap (similar to fibers 551-553) in z7 amp B (as has already been documented). CCD_X=2057:3724 (the fiber is centered at 3719). Summary: all the above issues were related to charge traps, except for fibers 725 (unknown issue) and 3504 (due to unmasked bad columns). Remaining fibers to look at (all of them were also identified in the Y1 iron): 466, 1008, 1098, 3994, 4720, 4891. Need to understand fiber 725 too. |
Julien and I have gone through all the fibers. Here are our findings (and the fixes that we have implemented for some of the fibers). Some of the information might be redundant with my previous post. 466: already flagged in Y1. Nothing obvious. ~20% low flat field. 551-553: The beginning of a CTE charge trap (tracked by #2286). 725: the fiber trace lies on top of a vertical band of excess charge (~15 elec) in z1 amplifier A that we see in master bias frames (probably induced by the parallel clocking at the transfer gate?). This excess charge is fluctuating a bit during the night causing offsets in the spectra. We don’t think it requires masking out the CCD column. We suggest only flagging the fiber for the LSS catalog. 1008: charge trap along the parallel at CCD_X=190, CCD_Y=1901 that was not sufficiently masked. We have now fixed this by extending the size of the mask. This fix has been pushed to SVN. 1098: symptom: discontinuity between blue and red caused by excess flux in blue (see example spectrum below). No signal of any problem in bias,dark,flat,psf. Related to TPCORR parameter in BLUE which could be the cause or another symptom. Seen as outlier in TPCORR blue only (see below for other cases) 3234-3254: r6 CTE first detected on May 21, 2023; we switched to 2-amp mode on March 25, 2024. Software correction for CTE in place with simple sector offset; this correction might be not sufficient. CCD_X range of CTE correction: 1905-2057; this corresponds to fibers 3234-3254. We also see the CTE pattern in the dark. 3504: appears to be a bad column in the dark at CCD_X=177:178 (the fiber is centered at 174) in r7; the two bad columns have no signal in the flats (see below). The resulting spurious redshifts first appeared after summer 2022. We masked the two bad columns and committed in SVN. 3969: Also at the beginning of a CTE charge trap (similar to 551-553) in z7 amp B (as has already been documented). CCD_X=2057:3724 (the fiber is centered at 3719). 3994: we suspect that it's a problem with tpcorr, because this fiber is an outlier in tpcorr parameters in R camera but not in B camera (and we expect them to be consistent as the tpcorr correction should be achromatic). 4720, 4891: We are also finding large TPCORR values for those fibers. For 4891, the values are mostly identical for all cameras. For 4720, we find a large TPCORR value only in r band.
|
Summary from @rongpu's 2024-07-23 data telecon presentation, slightly augmented from discussion
|
@schlafly pointed out that there are problems with fibers 918-921 that were identified from Tertiary 37. It's also causing spurious LRGs redshifts starting ~Jan 2024 (see below). They were not flagged by the K-S test presumably because only a small portion of the data was affected. |
I ve not followed all the details in this ticket, but if useful / complementary: those 918-921 fibers likely are the "spike" in red dots here, for 20240304 (reaching the y=1 line): @rongpu: it may be worth it to check few fibers around those values, as this "918-921" comes from tertiary37, where the stats are not great. pdf files here (those are heavy, 100-400M each!): |
Building upon your previous work on fiber outlier detection, I've identified three additional fibers that exhibit atypical behavior in their LRG redshift distributions. These fibers were not previously mentioned in this issue, so I'm reporting them for further investigation. Newly Identified Atypical Fibers:
I've attached plots for each fiber showing:
The full analysis notebook is available here. Do you think these fibers warrant further investigation? Are there any known issues or characteristics of these specific fibers that might explain their behavior? |
650, 675 are hit by the z1 CTE. I would guess that 700, 725, and potentially 750 are also affected. Because they're the first fiber in a block of 25 they are more sensitive to the trap modeling than the others; apparently the fit isn't doing a good job there. z3C has a serious CTE which vaguely matches that date range. That looks like it might be roughly the last fiber affected by the problematic region, which I wouldn't have thought was as special of a case (i.e., it lies right on the amp boundary). |
Thanks @forero! These fibers have somewhat low p-values in my K-S test but still above the 1e-4 threshold. Is fiber 1754 also a CTE issue? I spot checked a few of its z=~1.7 spectra (see an example below), and there's nothing obviously wrong –– it seems that this fiber simply have more featureless spectra than the other fibers. |
For convenience I have created PDFs that includes the per-fiber redshift QA plots for all 5000 fibers: |
Tracking has been moved to spreadsheet (don't post link here since this is too public). |
Repeat the exercise in issue #1946, I have identified the following 15 fibers in jura with K-S test p-value less than 1e-4 for either BGS (14 fibers) or LRG (10 fibers):
466, 551, 552, 553, 725, 1008, 1098, 3234, 3235, 3250, 3504, 3969, 3994, 4720, 4891
Below are redshift vs date plots for these fibers:
FIBER 466
BGS
FIBER 551
BGS
FIBER 552
BGS
LRG
FIBER 553
BGS
LRG
FIBER 725
LRG
FIBER 1008
BGS
LRG
FIBER 1098
BGS
FIBER 3234
BGS
LRG
FIBER 3235
BGS
LRG
FIBER 3250
BGS
LRG
FIBER 3504
BGS
LRG
FIBER 3969
BGS
LRG
FIBER 3994
BGS
LRG
FIBER 4720
BGS
FIBER 4891
BGS
The text was updated successfully, but these errors were encountered: