select calib dark with most cameras; fixes 20231028 for Jura #2253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2247 where the pipeline was generating a ccdcalib job for camword a01456789 but later needing CTE corrections for z3 not included in that camword.
The underlying reason was that the job camword is tied to the selected dark, and
select_calibrations_to_proc
was picking the first calib dark instead of the one with the most available cameras.With this PR,
desi_proc_night -n 20231028 --dry-run-level 1
now selects a different dark and generates a ccdcalib job for all cameras.20231028 is the only night in Jura that I'm aware of that is impacted by this issue, though it is possible that other nights would pick a different dark with this branch.
Additional notes:
select_calib_dark(etable)
. Upstream from that function theetable
had already been filtered to 300 second darks. In general, I think we'd prefer a longer dark with more cameras over a 300 sec dark with fewer cameras, but I'm unaware of a night where that distinction matters so I didn't change that here. In the futureselect_valid_calib_exposures
could be more permissive about what dark exposure times are allowable, and this new functionselect_calib_dark
could include EXPTIME in its ranking consideration.