restore w1/w2 flux argument to iselg_colors

[moustakas]

Near-trivial fix for an unintended change to the isELG API introduced in #513.

[geordie666]

Thanks for the quick work on this. One comment:

I think you'll need the exact same changes in py/desitarget/sv1/sv1_cuts.py? Specifically here:

https://github.com/desihub/desitarget/blob/elg-w12flux/py/desitarget/sv1/sv1_cuts.py#L903

A second comment:

You'll also need to pass w1flux and w2flux to isELG(). Here:

https://github.com/desihub/desitarget/blob/elg-w12flux/py/desitarget/sv1/sv1_cuts.py#L853-L854

and in the sv1_cuts.py code.

[geordie666]

I think this will work, now. Strictly, for completeness, you might want to pass w1flux and w2flux in the main survey cuts code, too:

desitarget/py/desitarget/cuts.py

Line 259 in d151c91

def isELG(gflux=None, rflux=None, zflux=None, gsnr=None, rsnr=None, zsnr=None,

That's your call (I think the code will work without failing, either way). Feel free to merge at your leisure.

[moustakas]

Although I accidentally retriggered tests, I'm going to go ahead and merge. I tested select_mock_targets with these changes with all target classes for both the main and sv1 surveys.

Thanks for your help, @geordie666.

[geordie666]

Excellent. If you don't think the mocks are going to fail on maskbits now being passed out of _prepare_optical_wise:

desitarget/py/desitarget/cuts.py

Lines 1938 to 1947 in 01c930a

	# ADM process the Legacy Surveys columns for Target Selection.
	photsys_north, photsys_south, obs_rflux, gflux, rflux, zflux, \
	w1flux, w2flux, rfiberflux, objtype, release, \
	gfluxivar, rfluxivar, zfluxivar, \
	gnobs, rnobs, znobs, gfracflux, rfracflux, zfracflux, \
	gfracmasked, rfracmasked, zfracmasked, \
	gfracin, rfracin, zfracin, gallmask, rallmask, zallmask, \
	gsnr, rsnr, zsnr, w1snr, w2snr, \
	dchisq, deltaChi2, brightstarinblob, maskbits = \
	_prepare_optical_wise(objects, colnames=colnames)

Then we should be good to go.

Apologies for breaking this at such short notice.

[geordie666]

Sorry, missed your last comment. If select_mock_targets works, then all is good.