Add different Table reader options to mtl.update_ledger() #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #822 added different astropy table reader options for MTL I/O. The alt-MTL mocks specifically use
desitarget.mtl.update_ledger()as a worker function, though, and PR #822 neglected to also add the different table reader options to that function.This PR augments PR #822 by also adding the
tabformkwarg todesitarget.mtl.update_ledger()to facilitate different astropy table reader arguments for the alt-MTL mocks.This is a small PR, and I've carefully checked that I haven't broken anything about the MTL loop on the data side, so I'll merge in a few hours.