Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission settings in fix_permissions.sh #126

Merged
merged 5 commits into from
Nov 14, 2018

Conversation

weaverba137
Copy link
Member

This PR modifies the permissions that fix_permissions.sh fixes.

fix_permissions.sh will

  • Change group ownership to 'desi'.
  • Ensure files and directories are readable by the desi group.
  • Optionally, make files readable by apache for http access (with -a option).

and that's it. In particular, no attempt is made to alter group write, user write, or any world permissions.

I need to test before merging, but wanted to get the discussion going.

@weaverba137 weaverba137 added the WIP Work in Progress label Nov 14, 2018
@weaverba137 weaverba137 self-assigned this Nov 14, 2018
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 . Works as expected (after understanding my umask to update my expectations...)

@weaverba137
Copy link
Member Author

I need to update the test_permissions.sh script and clean up some commented code before merging.

@weaverba137 weaverba137 removed the WIP Work in Progress label Nov 14, 2018
@weaverba137
Copy link
Member Author

This should be ready to merge as soon as final tests pass.

@weaverba137 weaverba137 merged commit 52bd24d into master Nov 14, 2018
@weaverba137 weaverba137 deleted the review-permissions branch November 14, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants