Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pip install #168

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Switch to pip install #168

merged 3 commits into from
Mar 29, 2021

Conversation

weaverba137
Copy link
Member

This PR closes #167. In addition to a simple replacement of python setup.py install with the equivalent pip install ., this PR

  • Updates the known packages.
  • Begins preparation for the transition to Lmod-based modules.

@weaverba137 weaverba137 self-assigned this Mar 29, 2021
@coveralls
Copy link

coveralls commented Mar 29, 2021

Coverage Status

Coverage decreased (-0.01%) to 68.032% when pulling 721fff0 on pip-install into 3ce49f0 on master.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

It looks like the pip_safe list in install.py isn't used yet. Is that correct? ok to leave it as is, or consider _pip_safe hiding it or commenting it out if not needed. Since we have a mix of packages, I like that the current method appears to automatically detect what to do rather than requiring a proactive opt-in list to be maintained, so we may never need this.

@weaverba137
Copy link
Member Author

Indeed, pip_safe is "reserved for future use". I'll comment it out for now, then merge & tag.

@weaverba137 weaverba137 merged commit 3ec76bc into master Mar 29, 2021
@weaverba137 weaverba137 deleted the pip-install branch March 29, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate desiInstall to pip
3 participants