Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds checks to radec_to_desiname #207

Merged
merged 11 commits into from
May 14, 2024
Merged

Add bounds checks to radec_to_desiname #207

merged 11 commits into from
May 14, 2024

Conversation

weaverba137
Copy link
Member

This PR closes #206.

In addition the test matrix is updated to bring the tests more in line with Jura (hence the oddball branch name).

@weaverba137 weaverba137 self-assigned this May 7, 2024
Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix, Ben. I am happy to accept your changes as-is but I left two things in-line for you to consider.

py/desiutil/names.py Outdated Show resolved Hide resolved
py/desiutil/test/test_names.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 7, 2024

Coverage Status

coverage: 76.331% (+0.05%) from 76.284%
when pulling afea081 on numpy-1.23
into 3cb282b on main.

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my previous comments still remain after this update. You're welcome to ignore them if you wish. I have added one additional comment you can choose to address or not.

Feel free to accept or reject any of the three and merge if satisfied.

py/desiutil/names.py Outdated Show resolved Hide resolved
@weaverba137
Copy link
Member Author

I will review those soon. I was just very busy debugging the tests yesterday.

@weaverba137
Copy link
Member Author

@sbailey, there is a remaining question about how specific we want to make the error messages, for example not just saying "bad value found", but "25 instances of bad values of target_ra found, for example 375 at index 244 of target_ra".

It wouldn't necessarily be that hard to implement something like that, but why can't users just do that themselves?

@weaverba137
Copy link
Member Author

Based on discussion with @sbailey yesterday, I think this can be merged in the current state. I will merge shortly unless there are further comments.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, ok to merge.

@weaverba137 weaverba137 merged commit bdc44d9 into main May 14, 2024
28 checks passed
@weaverba137 weaverba137 deleted the numpy-1.23 branch May 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

radec_to_desiname should include bounds checks
4 participants