add new sklearn.GaussianMixtureModel functionality #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moustakas, You requested my review on this, but didn't actually give me a chance to review it. For urgent cases like this, please ping me if I don't see it right away. Could you please update the change log, |
|
PS, the documentation of the module itself is extremely sparse. |
|
@moustakas are you listening? |
|
@moustakas <https://github.com/moustakas> is traveling today, so he's only
in intermittent contact...
…On Fri, Feb 17, 2017 at 3:00 PM, Benjamin Alan Weaver < ***@***.***> wrote:
@moustakas <https://github.com/moustakas> are you listening?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANTmRXfP6BIgszHB4ri-sKP8d5qil8Wpks5rdhiagaJpZM4MA934>
.
|
This was referenced Feb 19, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new module semi-arbitrarily called
sklearnwhich contains theGaussianMixtureModelclass taken from sklearn. This class was previously indesisim.templatesbut now it is needed by both the template-generating code anddesitarget.mock.io(as part of desihub/desitarget#136; see also desihub/desitarget#106 and dr2_mag_distributions.ipynb.I called it sklearn in case we decide to pull in other functionality without introducing an unnecessary dependence but we can easily change the name.
[Thanks to @dkirkby, who originally pulled this piece out of sklearn.]