Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new sklearn.GaussianMixtureModel functionality #54

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Conversation

moustakas
Copy link
Member

This PR adds a new module semi-arbitrarily called sklearn which contains the GaussianMixtureModel class taken from sklearn. This class was previously in desisim.templates but now it is needed by both the template-generating code and desitarget.mock.io (as part of desihub/desitarget#136; see also desihub/desitarget#106 and dr2_mag_distributions.ipynb.

I called it sklearn in case we decide to pull in other functionality without introducing an unnecessary dependence but we can easily change the name.

[Thanks to @dkirkby, who originally pulled this piece out of sklearn.]

@moustakas moustakas merged commit eb25e43 into master Feb 16, 2017
@moustakas moustakas deleted the mixture branch February 16, 2017 14:03
@weaverba137
Copy link
Member

@moustakas, You requested my review on this, but didn't actually give me a chance to review it. For urgent cases like this, please ping me if I don't see it right away.

Could you please update the change log, doc/changes.rst, and add desiutil.sklearn to the API documentation, doc/api.rst? Please also verify that the documentation builds without errors.

@weaverba137
Copy link
Member

PS, the documentation of the module itself is extremely sparse.

@weaverba137
Copy link
Member

@moustakas are you listening?

@geordie666
Copy link
Contributor

geordie666 commented Feb 17, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants