-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of --extcap-version command line parameter #53
Conversation
Since Wireshark 2.9 the extcap call to query its interface is extended with the extcap-version parameter. The command line option parser is not expecting this, emitting a message in stderr. This change adds the extcap-version parameter to the expected set, to stop the message being emitted on stderr, leaving out any processing of the parameter value itself, which USBPcapCMD does not need, yet.
Hey Jaap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine on my Windows 10 laptop with Wireshark 2.9.0rc0-1285
Note that 1) the version argument to Note also that the only way to pass an optional argument to an option that is supported by all versions of |
@guyharris I will change the argument parser to support the optional argument. However, I am somehow lost in understanding --extcap-version. Could you please answer following questions to clarify:
Regardless if --extcap-version is called with or without parameter, if extcap does not fail, it should print the tool version (the 1.2.0.4 for upcoming USBPcap)? And if extcap is called without --extcap-version at all, but with the --extcap-interfaces (old version of Wireshark), is it safe to print the "extcap {version=a.b.c.d}{help=someurl}" alongside the interfaces? |
Let's move this conversation under the open issue #51 |
Since Wireshark 2.9 the extcap call to query its interface is extended
with the extcap-version parameter. The command line option parser is
not expecting this, emitting a message in stderr.
This change adds the extcap-version parameter to the expected set, to
stop the message being emitted on stderr, leaving out any processing
of the parameter value itself, which USBPcapCMD does not need, yet.