Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haptic feedback does not work #420

Closed
LenzGr opened this issue Sep 18, 2023 · 9 comments
Closed

Haptic feedback does not work #420

LenzGr opened this issue Sep 18, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@LenzGr
Copy link

LenzGr commented Sep 18, 2023

Thumb-Key Version
2.0.0 (installed from GitHub)

Describe the bug
Even though the haptic feedback option is enabled in the settings, there's no haptic feedback. This happens on a OnePlus 7T, running OxygenOS 12.1 (Android12).

To Reproduce
Steps to reproduce the behavior:

  1. Ensure that haptic feedback is enabled in the settings.
  2. Type some text.
  3. Observe that no haptic feedback is provided.
@LenzGr LenzGr added the bug Something isn't working label Sep 18, 2023
@dessalines
Copy link
Owner

Its an android system issue, go to your android settings -> vibration and haptic strength -> touch feedback ON

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
@alerque
Copy link

alerque commented Sep 19, 2023

It might be worth adding a comment under this setting that it must also be enabled in the system settings. This isn't the fault of this app but it is a common point of confusion with apps that have their own haptic settings.

@dessalines
Copy link
Owner

I'm not sure of a less verbose way to say that for the setting.

@alerque
Copy link

alerque commented Sep 19, 2023

Right now the setting reads:

Vibrate on tap

I would propose a byline on that setting much like the settings above it have

Vibrate on tap

(requires touch feedback to be enabled in system settings)

If it is possible to query the system setting status, the setting could be greyed out in the event the system setting is enabled and the byline could read "disabled via system touch feedback settings", and no byline at all would be required if the system setting was on anyway.

@LenzGr
Copy link
Author

LenzGr commented Sep 19, 2023

I wonder if there is an alternative way to generate this haptic feedback even if touch feedback is disabled?
The Android Game Vector Pinball is capable of triggering short vibration events even when the setting is off.

@alerque
Copy link

alerque commented Sep 19, 2023

I'm sure there is. Personally I would prefer it respect the global default so that I can toggle them system-wide from a tile and/or notification profile. I don't appreciate it when apps don't respect the system settings and do their own thing.

@LenzGr
Copy link
Author

LenzGr commented Sep 19, 2023

I'm sure there is. Personally I would prefer it respect the global default so that I can toggle them system-wide from a tile and/or notification profile. I don't appreciate it when apps don't respect the system settings and do their own thing.

Well, then this option should be removed, as it does exactly that, doesn't it?

@alerque
Copy link

alerque commented Sep 19, 2023

No. This option allows the ability to not have feedback for the keyboard even if the system level general feedback option is on.

Edit: Perhaps it should be renamed and that would help the clarity. The default could be on, and the setting could be to "disable" it in the event the system setting was on.

@dessalines
Copy link
Owner

Vibrate on tap
(requires touch feedback to be enabled in system settings)

@alerque This seems like the best solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants