Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better User Guide section in README #430

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Conversation

KraXen72
Copy link
Contributor

I rewrote the User Guide section to be more aligned with the new features of thumb-key 2.0.0. I have not tested if the in-app link to the guide still works, but i haven't changed the section's name, so it should.

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thx! Just run prettier on this file to fix any formatting issues.

README.md Show resolved Hide resolved
@KraXen72
Copy link
Contributor Author

I implemented the requested changes. Please take a look @dessalines

@KraXen72
Copy link
Contributor Author

build failed because some other reason (daemon dissapeared), the check_formatting step passed

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll handle that one. Thx for this!

@dessalines dessalines enabled auto-merge (squash) September 21, 2023 13:09
@dessalines dessalines merged commit 824f30e into dessalines:main Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants