Sort /help #182
Merged
Sort /help #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: separate admin commands from regular ones
11k
requested changes
Mar 18, 2023
There was a problem hiding this comment.
This chaining of static methods here bothers me a lot. Let's take a step back and refactor this.
- Move the
commandsinfoobject into a separate module. - Simplify the object's structure by removing the unnecessary arrays.
- Manually alphabetize the object.
- Create and export a class in this module for command-related operations.
- Add whatever methods to this class you think are necessary to do what you need.
- Write unit tests for the method that generates a help string.
11k
requested changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179.
Sorts /help alphabetically, also separates admin commands from regular ones. Admin commands only show up if you have mod powers.