Rework cache #313
Merged
Rework cache #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertdstein
force-pushed
the
minobssummary
branch
from
a6d1dfb
to
e8aaf91
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the cache structure, and removes some existing redundancy. It introduces a central paths.py to contain directories. The various files are saved to caches based either on the name of the parent event (e.g for candidate PDFs), OR the name of the ZTF source if it is event-agnostic (e.g crossmatching).
It updates the crossmatching for WISE, to display the nearest source if there are multiple matches.
It adds some scattered docstrings introduced as I went though the code.
It comments out the buggy GRB name code (#312), and associated test.
It also updates the pre-commit to use isort (which sorts imports).