New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default M-SEARCH max response delay to 1 second #6

Merged

detached merged 1 commit into detached:develop from simon816:better-response-delay-default

Sep 22, 2023

Contributor

simon816 commented Sep 19, 2023

The spec states the following (from https://openconnectivity.org/upnp-specs/UPnP-arch-DeviceArchitecture-v2.0-20200417.pdf)

MX
Required. Field value contains maximum wait time in seconds. shall be greater than or equal to 1 and should
be less than 5 inclusive. Device responses should be delayed a random duration between 0 and this many
seconds to balance load for the control point when it processes responses.

So 0 is not valid. It appears that chromecasts will not respond to a delay of 0.


          Set default M-SEARCH max response delay to 1 second

82f8e32

Owner

detached commented Sep 22, 2023

Thank you very much for contributing this!

Just for completeness: the dial 2.1 protocol uses upnp 1.1 (http://www.upnp.org/specs/arch/UPnP-arch-DeviceArchitecture-v1.1.pdf)
But that doesn't change that you are completely right here.

detached merged commit 69bf798 into detached:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet