Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancements and fixes for RetroPie scriptmodule #24

Closed
wants to merge 1 commit into from
Closed

enhancements and fixes for RetroPie scriptmodule #24

wants to merge 1 commit into from

Conversation

Gemba
Copy link

@Gemba Gemba commented Apr 25, 2023

In order of the changes in the file:

  • Set repo URL in scriptmodule header, also for generating a proper retropie.pkg
  • Set VERSION to indicate this branch
  • Sifted out files that will land in the binary/$md_inst folder
  • Compacted config file copy section by using RP provided functions, plus:
  • Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json,screenscraper.json
  • Removed some trailing spaces

@Gemba Gemba mentioned this pull request Apr 25, 2023
Open
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Apr 27, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
37e7fd3 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Apr 27, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
d0c1ddf 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
@s1eve-mcdichae1 s1eve-mcdichae1 mentioned this pull request Apr 27, 2023
Merged
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Aug 2, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
3918c1a 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Aug 2, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
5e25a39 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Aug 2, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes (#5)
45be1d5 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Sep 28, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes (#5)
a1e2d42 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 1, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes (#5)
800fc80 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Set VERSION to indicate this branch

- Sifted out files that will land in the $md_inst folder

- Compacted config file copy section by using RP provided functions, plus:

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 1, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes (#5)
446e8da 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork

- https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add mobygames.json

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Removed some trailing spaces
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 5, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes (#5)
c19482d 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork:

https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Minor cleanup:

Removed some trailing spaces

Removed errant ']]'

hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

Fix typo in comment
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 5, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
0ab5aa1 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork:

https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Minor cleanup:

Removed some trailing spaces

Removed errant ']]'

hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

Fix typo in comment
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 5, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
030e23f 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork:

https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Avoid overwrite of changes in artwork.xml, aliasMap.csv, platforms.json, screenscraper.json

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Minor cleanup:

Removed some trailing spaces

Removed errant ']]'

hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

Fix typo in comment
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 6, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
e174563 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Add docs/ folder

- hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Don't use unix:examples.files

- Minor cleanup:
-- Removed some trailing spaces
-- Removed errant ']]'
-- Fix typo in comment
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 6, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
82219a8 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Add docs/ folder

- hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Don't use unix:examples.files -- Copy resource files explicitly

- Minor cleanup:
-- Removed some trailing spaces
-- Removed errant ']]'
-- Fix typo in comment
s1eve-mcdichae1 added a commit to s1eve-mcdichae1/RetroPie-Setup that referenced this pull request Oct 7, 2023
@s1eve-mcdichae1
skyscraper.sh - enhancements and fixes
c9fcb57 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Add docs/ folder

- hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Don't use unix:examples.files -- Copy resource files explicitly

- Minor cleanup:
-- Removed some trailing spaces
-- Removed errant ']]'
hissingshark pushed a commit to hissingshark/RetroPie-Setup that referenced this pull request Oct 29, 2023
@s1eve-mcdichae1 @hissingshark
skyscraper.sh - enhancements and fixes
4b476a1 
Co-authored-by: Gemba <uid0@sdf-eu.org>

From detain/skyscraper#24

Gemba/skyscraper@47868bd

- Switch to active fork https://github.com/Gemba/skyscraper

- Compacted config file copy section by using RP provided functions, plus:

- Add platforms.json, mobygames.json, screenscraper.json

- Add docs/ folder

- hints.txt > hints.xml (Version 3.5.4 - 14th May 2020)

- Revert commit 693dbfd ("prevent hall of mirrors effect") - This is now implemented upstream in the new fork

- Don't use unix:examples.files -- Copy resource files explicitly

- Minor cleanup:
-- Removed some trailing spaces
-- Removed errant ']]'
@Gemba Gemba closed this Jan 26, 2024
@Gemba Gemba deleted the fb_enhancements_rp_scriptmodule branch January 26, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gemba