Remove duplicate configurations for reports. #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the 2 functions to configure reports fun reports(closure: Closure<*>): DetektReports = ConfigureUtil.configure(closure, reports) fun reports(configure: DetektReports.() -> Unit) = reports.configure() with one single function (thank you @JLLeitschuh for the hint) that works for both groovy and kotlin dsl.
|
I commented a bunch of other things too but this was a big one. Hahah. I'm glad you caught that feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right before #1194 was merged @JLLeitschuh commented that the functions that let the user configure reports can be expressed by a single function using an
Action.