Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude inline classes as they are a light form of data class - Closes #1450 #1454

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.0.0 milestone Feb 5, 2019
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #1454 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1454      +/-   ##
============================================
+ Coverage     74.62%   74.65%   +0.02%     
- Complexity     1716     1717       +1     
============================================
  Files           326      326              
  Lines          5171     5176       +5     
  Branches        935      939       +4     
============================================
+ Hits           3859     3864       +5     
  Misses          788      788              
  Partials        524      524
Impacted Files Coverage Δ Complexity Δ
...tlab/arturbosch/detekt/rules/style/UseDataClass.kt 80.55% <100%> (+2.43%) 28 <6> (+1) ⬆️
...o/gitlab/arturbosch/detekt/rules/KtModifierList.kt 90% <100%> (+1.11%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cfcfb...6cacc40. Read the comment docs.

@vanniktech
Copy link
Contributor

Thank you ❤️

@arturbosch arturbosch merged commit f741297 into master Feb 5, 2019
@arturbosch arturbosch deleted the inline-classes branch February 5, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants