Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RedundantVisibilityModifierRule to find redundant internal modifiers #3092

Merged
merged 3 commits into from
Sep 26, 2020

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 19, 2020

There were some redundant internal modifiers identified by the IDE that weren't picked up by detekt's own rule, so I updated the rule to find this type of usage.

I also enabled the rule for detekt self-scans and fixed the reported issues.

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #3092 into master will decrease coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3092      +/-   ##
============================================
- Coverage     79.28%   79.27%   -0.01%     
- Complexity     2577     2579       +2     
============================================
  Files           435      435              
  Lines          7766     7774       +8     
  Branches       1482     1484       +2     
============================================
+ Hits           6157     6163       +6     
  Misses          819      819              
- Partials        790      792       +2     
Impacted Files Coverage Δ Complexity Δ
...n/io/github/detekt/metrics/processors/util/LLOC.kt 73.33% <ø> (ø) 3.00 <0.00> (ø)
...rbosch/detekt/rules/complexity/NestedBlockDepth.kt 91.83% <66.66%> (ø) 5.00 <0.00> (ø)
...ekt/rules/style/RedundantVisibilityModifierRule.kt 95.45% <77.77%> (-4.55%) 9.00 <2.00> (+2.00) ⬇️
...bosch/detekt/rules/bugs/EqualsWithHashCodeExist.kt 88.88% <100.00%> (ø) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52f6f2...17dedc6. Read the comment docs.

Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@arturbosch arturbosch merged commit eb11cdf into detekt:master Sep 26, 2020
@arturbosch arturbosch added this to the 1.14.0 milestone Sep 26, 2020
@3flex 3flex deleted the redundant-internal branch September 26, 2020 23:42
@3flex 3flex restored the redundant-internal branch July 29, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants