Update RedundantVisibilityModifierRule to find redundant internal modifiers#3092
Merged
arturbosch merged 3 commits intodetekt:masterfrom Sep 26, 2020
Merged
Update RedundantVisibilityModifierRule to find redundant internal modifiers#3092arturbosch merged 3 commits intodetekt:masterfrom
arturbosch merged 3 commits intodetekt:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3092 +/- ##
============================================
- Coverage 79.28% 79.27% -0.01%
- Complexity 2577 2579 +2
============================================
Files 435 435
Lines 7766 7774 +8
Branches 1482 1484 +2
============================================
+ Hits 6157 6163 +6
Misses 819 819
- Partials 790 792 +2
Continue to review full report at Codecov.
|
schalkms
approved these changes
Sep 19, 2020
cortinico
reviewed
Sep 20, 2020
...c/test/kotlin/io/gitlab/arturbosch/detekt/rules/style/RedundantVisibilityModifierRuleSpec.kt
Outdated
Show resolved
Hide resolved
cortinico
approved these changes
Sep 20, 2020
arturbosch
approved these changes
Sep 25, 2020
c49a265 to
0e0c92a
Compare
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
0e0c92a to
17dedc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some redundant
internalmodifiers identified by the IDE that weren't picked up by detekt's own rule, so I updated the rule to find this type of usage.I also enabled the rule for detekt self-scans and fixed the reported issues.