Fix false negatives in UnreachableCode rule#3220
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3220 +/- ##
============================================
+ Coverage 80.06% 80.09% +0.02%
- Complexity 2645 2647 +2
============================================
Files 440 440
Lines 8012 8012
Branches 1535 1531 -4
============================================
+ Hits 6415 6417 +2
Misses 775 775
+ Partials 822 820 -2
Continue to review full report at Codecov.
|
BraisGabin
approved these changes
Nov 9, 2020
schalkms
requested changes
Nov 9, 2020
schalkms
left a comment
Member
There was a problem hiding this comment.
Thanks for submitting this PR! The rule is now more sophisticated than ever before with the help of type and symbol solving. 🙂
Consequently, this change is breaking. We would need to add the require annotation to the rule comment.
Furthermore, the check for an empty bindingContext is missing in my opinion.
schalkms
approved these changes
Nov 10, 2020
arturbosch
pushed a commit
that referenced
this pull request
Dec 21, 2020
* Fix false negatives in UnreachableCode rule * Add @requiresTypeResolution
arturbosch
pushed a commit
that referenced
this pull request
Jan 16, 2021
* Fix false negatives in UnreachableCode rule * Add @requiresTypeResolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3219