-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false negatives in UnreachableCode rule #3220
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3220 +/- ##
============================================
+ Coverage 80.06% 80.09% +0.02%
- Complexity 2645 2647 +2
============================================
Files 440 440
Lines 8012 8012
Branches 1535 1531 -4
============================================
+ Hits 6415 6417 +2
Misses 775 775
+ Partials 822 820 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR! The rule is now more sophisticated than ever before with the help of type and symbol solving. 🙂
Consequently, this change is breaking. We would need to add the require annotation to the rule comment.
Furthermore, the check for an empty bindingContext is missing in my opinion.
* Fix false negatives in UnreachableCode rule * Add @requiresTypeResolution
* Fix false negatives in UnreachableCode rule * Add @requiresTypeResolution
Fixes #3219