Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility #3326

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Reduce visibility #3326

merged 2 commits into from
Jan 7, 2021

Conversation

BraisGabin
Copy link
Member

We don't need to expose the implementations outside the file. And we don't want to mix builders and actual implementations so we should not make the builders implement the interfaces.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #3326 (37406b7) into master (6b065a8) will decrease coverage by 0.02%.
The diff coverage is 94.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3326      +/-   ##
============================================
- Coverage     80.28%   80.25%   -0.03%     
+ Complexity     2714     2713       -1     
============================================
  Files           445      445              
  Lines          8196     8196              
  Branches       1558     1558              
============================================
- Hits           6580     6578       -2     
- Misses          778      780       +2     
  Partials        838      838              
Impacted Files Coverage Δ Complexity Δ
...github/detekt/tooling/dsl/ExtensionsSpecBuilder.kt 94.44% <80.00%> (-5.56%) 10.00 <2.00> (-1.00)
...io/github/detekt/tooling/dsl/ProjectSpecBuilder.kt 90.90% <83.33%> (-9.10%) 5.00 <4.00> (ø)
...o/github/detekt/tooling/dsl/BaselineSpecBuilder.kt 100.00% <100.00%> (ø) 4.00 <3.00> (ø)
...o/github/detekt/tooling/dsl/CompilerSpecBuilder.kt 100.00% <100.00%> (ø) 5.00 <4.00> (ø)
.../io/github/detekt/tooling/dsl/ConfigSpecBuilder.kt 89.47% <100.00%> (ø) 7.00 <6.00> (ø)
.../github/detekt/tooling/dsl/ExecutionSpecBuilder.kt 100.00% <100.00%> (ø) 5.00 <4.00> (ø)
...io/github/detekt/tooling/dsl/LoggingSpecBuilder.kt 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...github/detekt/tooling/dsl/ProcessingSpecBuilder.kt 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
...io/github/detekt/tooling/dsl/ReportsSpecBuilder.kt 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
...n/io/github/detekt/tooling/dsl/RulesSpecBuilder.kt 94.73% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b065a8...37406b7. Read the comment docs.

@schalkms schalkms merged commit cde7b23 into detekt:master Jan 7, 2021
@BraisGabin BraisGabin deleted the refactor-tooling branch January 7, 2021 13:57
arturbosch pushed a commit that referenced this pull request Jan 16, 2021
* Reduce visibility

* Builders should not implement the interface
@arturbosch arturbosch added this to the 1.16.0 milestone Jan 18, 2021
@arturbosch arturbosch added the housekeeping Marker for housekeeping tasks and refactorings label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants