-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show information from @active in the website #3569
Conversation
a1a2164
to
5b85c6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
=========================================
Coverage 77.53% 77.53%
- Complexity 2829 2835 +6
=========================================
Files 464 464
Lines 8769 8779 +10
Branches 1713 1720 +7
=========================================
+ Hits 6799 6807 +8
Misses 1046 1046
- Partials 924 926 +2
Continue to review full report at Codecov.
|
5b85c6c
to
6fd70d7
Compare
### NoUnitKeyword | ||
|
||
removes :Unit | ||
|
||
**Active**: Yes - Since v1.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make it more clear that this is a default value? I mean, that this rule is active by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the label it as "Active by default"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add it just for the ones that are active by default? I like it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it for both actually. I think it's better to be explicit rather than implicit, or is there a reason why we want to hide it for disabled rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this as it is, and we can still re-discuss this if needed.
Fixes #3568
The information from the
@active
KDoc annotation can be easily added to the website to make easier for our user to understand if a rule is active or not.I've also cleaned up a bit the
@since
annotation as it was not really used.