Added support for special handling in RethrowCaughtException #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not report caught exception that are rethrown if there is work done before that. reference #906
vanniktech
approved these changes
May 16, 2018
|
Please add test cases for just logging a message and not using the exception. |
arturbosch
reviewed
May 20, 2018
| fun x() { | ||
| try { | ||
| } catch (e: IllegalStateException) { | ||
| print("log") |
There was a problem hiding this comment.
According to sonar this should get reported, should't it? (https://sbforge.org/sonar/rules/show/squid:S1166?modal=true&layout=false)
// Noncompliant - exception is lost (only message is preserved)
try { /* ... */ } catch (Exception e) { LOGGER.info(e.getMessage()); }
The exception name must be used in any statement to not lose the exception?
There was a problem hiding this comment.
So should we make the rule stricter? @arturbosch
So this gets reported
try {
} catch (e: Exception) {
log()
log(e.message)
throw e
}and this does not
try {
} catch (e: Exception) {
log(e) // e is used here
throw e
}There was a problem hiding this comment.
I would say yes, lets how I interpret sonarqube's doc.
The rule checks if the rethrown caught exception is used before.
arturbosch
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference #906