Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gateway startup without pwdless sudo #9382

Merged
merged 2 commits into from
May 20, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented May 16, 2024

Ticket

Description

Test Plan

no release testing needed

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.49%. Comparing base (5ea0713) to head (5bd347a).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           notebook_proxy_feature_branch    #9382   +/-   ##
==============================================================
  Coverage                          46.49%   46.49%           
==============================================================
  Files                                743      743           
  Lines                             106596   106596           
  Branches                            2404     2405    +1     
==============================================================
  Hits                               49566    49566           
  Misses                             56835    56835           
  Partials                             195      195           
Flag Coverage Δ
backend 34.23% <ø> (ø)
harness 64.07% <ø> (ø)
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hamidzr hamidzr marked this pull request as ready for review May 16, 2024 16:53
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving this

@hamidzr hamidzr merged commit bc80a2a into notebook_proxy_feature_branch May 20, 2024
71 of 92 checks passed
@hamidzr hamidzr deleted the hz-nb-proxy1 branch May 20, 2024 20:22
hamidzr pushed a commit that referenced this pull request Jun 12, 2024
)

chore: gateway startup without pwdless sudo (#9382)

feat: translate gateway ports to proxied tasks (#9398)

chore: add a no-dependency multi-port multi-trial test exp (#9432)

feat: make gw port range configurable; add validation (#9458)

https://hpe-aiatscale.atlassian.net/browse/RM-267
https://hpe-aiatscale.atlassian.net/browse/RM-288

roughly rebased

building

tests running

newline

progress?

tests passing

working

cleanup

hopefully this fixes this

chore: bump up default gw listeners to 128 (#9474)

test: cherry pick port registry tests (#9471)

bump up slots per trial to 2 on a new set of tests

Reattach gateways (#9481)

docs: gateway docs part 1 (#9488)

also rename internal exposeProxyConfig var

helm values for bugbash

cpu slot types in helm values

more limited tests

better use test parametrize

some doc updates

document min k8s version

update the mtls notice

reset helm values

publish uncompressed docs

takeout test changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants