chore: add a no-dependency multi-port multi-trial test exp #9432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasBlaskey
approved these changes
May 28, 2024
|
|
||
| searcher: | ||
| max_length: 10000000 | ||
| name: adaptive_asha |
There was a problem hiding this comment.
maybe grid since it is simpler?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## notebook_proxy_feature_branch #9432 +/- ##
=================================================================
- Coverage 46.34% 36.55% -9.79%
=================================================================
Files 729 566 -163
Lines 105802 93579 -12223
Branches 2405 2405
=================================================================
- Hits 49036 34212 -14824
- Misses 56571 59172 +2601
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
hamidzr
merged commit f1801d1
into
notebook_proxy_feature_branch
76 of 92 checks passed
NicholasBlaskey
pushed a commit
that referenced
this pull request
Jun 3, 2024
NicholasBlaskey
pushed a commit
that referenced
this pull request
Jun 12, 2024
hamidzr
pushed a commit
that referenced
this pull request
Jun 12, 2024
) chore: gateway startup without pwdless sudo (#9382) feat: translate gateway ports to proxied tasks (#9398) chore: add a no-dependency multi-port multi-trial test exp (#9432) feat: make gw port range configurable; add validation (#9458) https://hpe-aiatscale.atlassian.net/browse/RM-267 https://hpe-aiatscale.atlassian.net/browse/RM-288 roughly rebased building tests running newline progress? tests passing working cleanup hopefully this fixes this chore: bump up default gw listeners to 128 (#9474) test: cherry pick port registry tests (#9471) bump up slots per trial to 2 on a new set of tests Reattach gateways (#9481) docs: gateway docs part 1 (#9488) also rename internal exposeProxyConfig var helm values for bugbash cpu slot types in helm values more limited tests better use test parametrize some doc updates document min k8s version update the mtls notice reset helm values publish uncompressed docs takeout test changes
NicholasBlaskey
pushed a commit
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.