-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate gateway ports to proxied tasks #9398
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## notebook_proxy_feature_branch #9398 +/- ##
=================================================================
- Coverage 46.49% 40.74% -5.76%
=================================================================
Files 743 665 -78
Lines 106596 77679 -28917
Branches 2405 0 -2405
=================================================================
- Hits 49567 31652 -17915
+ Misses 56834 46027 -10807
+ Partials 195 0 -195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
to the additionalrm
@@ -3171,11 +3171,11 @@ jobs: | |||
- run: | |||
name: Start defaultrm minikube | |||
command: | | |||
source tools/k8s/launch-minikube-with-gateway.sh defaultrm | |||
K8S_VERSION=1.29.5 source tools/k8s/launch-minikube-with-gateway.sh defaultrm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a specific kubernetes version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a version i've been running locally and I think the lowest we want to support as well. I think it'd be a good idea to have CI run the oldest version as well wdy think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally agree.
We need some way for updating it as new versions come out since previously it would just fall out of date then the tests would fail so we unpinned the version.
var started *sproto.ResourcesStarted | ||
// PERF: call once for all pods | ||
gwPortMap, err := p.gatewayService.getDeployedPortMap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job. I think this is a good start for reattach.
I've seen some priority setting integ tests fail here inconsistently. I also see it in the target branch (ignoring it for this PR)
|
4c2cc08
into
notebook_proxy_feature_branch
) chore: gateway startup without pwdless sudo (#9382) feat: translate gateway ports to proxied tasks (#9398) chore: add a no-dependency multi-port multi-trial test exp (#9432) feat: make gw port range configurable; add validation (#9458) https://hpe-aiatscale.atlassian.net/browse/RM-267 https://hpe-aiatscale.atlassian.net/browse/RM-288 roughly rebased building tests running newline progress? tests passing working cleanup hopefully this fixes this chore: bump up default gw listeners to 128 (#9474) test: cherry pick port registry tests (#9471) bump up slots per trial to 2 on a new set of tests Reattach gateways (#9481) docs: gateway docs part 1 (#9488) also rename internal exposeProxyConfig var helm values for bugbash cpu slot types in helm values more limited tests better use test parametrize some doc updates document min k8s version update the mtls notice reset helm values publish uncompressed docs takeout test changes
Ticket
https://hpe-aiatscale.atlassian.net/issues/RM-271
Description
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.